feat: restyle and simplify implementation of ResurrectGump
#1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IcculusC
commented
Aug 12, 2024
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Detected 20 dependenciesThird-party software listThis page lists the third-party software dependencies used in ModernUO
Contact Qodana teamContact us at [email protected]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a simple overhaul of the OSI style default
ResurrectGumpto have a little bit of personality. Unfortunately there are limitations with the associated cliloc message. It includes theCONTINUEandCANCELtext, and uses additional cliloc messages to label the buttons. See here for hints on what cliloc messages need to be updated if you wish to modify the gump copy.Additionally I refactored the gump to simplify the implementation and reuse the background/images in both styles.
ResurrectGumpResurrectGumpwith a price